[PATCH] D84334: [flang] Version information in flang/f18

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 17:09:12 PDT 2020


DavidTruby added inline comments.


================
Comment at: flang/tools/f18/CMakeLists.txt:33
 set(include ${FLANG_BINARY_DIR}/include/flang)
+set(include ${CMAKE_CURRENT_BINARY_DIR})
 
----------------
as a small nit: I think `target_include_directories(f18 ${CMAKE_CURRENT_BINARY_DIR})` is slightly cleaner. I'm not that fussed about it though


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84334/new/

https://reviews.llvm.org/D84334



More information about the llvm-commits mailing list