[llvm] 05aa29e - [docs] Mention LLVM_ENABLE_MODULES.

[David Blaikie via llvm-commits]

Probably "Enable Clang Header Modules during compilation" or "Compile
with Clang Header Modules"? in either case, make the "Clang Header
Modules" link to https://clang.llvm.org/docs/Modules.html ?

On Wed, Aug 12, 2020 at 8:05 AM Florian Hahn <flo at fhahn.com> wrote:
>
>
>
> On Mon, Aug 10, 2020 at 11:24 PM David Blaikie <dblaikie at gmail.com> wrote:
>>
>> On Tue, Aug 4, 2020 at 9:02 AM Florian Hahn via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> >
>> >
>> > Author: Florian Hahn
>> > Date: 2020-08-04T16:59:39+01:00
>> > New Revision: 05aa29efd7ecaea9631a3ac5c471a4a4749463a2
>> >
>> > URL: https://github.com/llvm/llvm-project/commit/05aa29efd7ecaea9631a3ac5c471a4a4749463a2
>> > DIFF: https://github.com/llvm/llvm-project/commit/05aa29efd7ecaea9631a3ac5c471a4a4749463a2.diff
>> >
>> > LOG: [docs] Mention LLVM_ENABLE_MODULES.
>> >
>> > Added:
>> >
>> >
>> > Modified:
>> >     llvm/docs/CMake.rst
>> >
>> > Removed:
>> >
>> >
>> >
>> > ################################################################################
>> > diff  --git a/llvm/docs/CMake.rst b/llvm/docs/CMake.rst
>> > index f96e34f21e80..da13726e8ca0 100644
>> > --- a/llvm/docs/CMake.rst
>> > +++ b/llvm/docs/CMake.rst
>> > @@ -306,6 +306,9 @@ LLVM-specific variables
>> >    scenario where a manual override may be desirable is when using Visual Studio
>> >    2017's CMake integration, which would not be detected as an IDE otherwise.
>> >
>> > +**LLVM_ENABLE_MODULES**
>> > +  Compile with C++ modules enabled.
>>
>> This might be ambiguous/confusing. I believe this enables what's
>> sometimes known as "Clang Header Modules" (might be worth a link to
>> some doc explaining what it is) - not C++20 standard modules.
>
>
> Oh right. Do you have any suggestions on how to improve the wording?
>
> Cheers,
> Florian
>