[PATCH] D85848: [InlineCost] Skip scalable vectors in visitAlloca

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 11:21:10 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:857
+  if (isa<ScalableVectorType>(I.getAllocatedType()))
+    return false;
+
----------------
This will refuse to inline any function with a scalable vector variable; that seems so conservative that it's likely to cause practical issues.  Please take the time to fix the code properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85848/new/

https://reviews.llvm.org/D85848



More information about the llvm-commits mailing list