[PATCH] D84549: [XCOFF][AIX] Support relocation generation for large code model

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked 2 inline comments as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:434
     // The FixedValue should be the TC entry offset from TOC-base.
     FixedValue = SectionMap[SymASec]->Address - TOCCsects.front().Address;
 
----------------
DiggerLin wrote:
> I am not sure whether I understand is correct or not ?
> FixedValue of intructions
> addis 3, L..C0 at u(2) . FixedValue should get the high 16bits of SectionMap[SymASec]->Address - TOCCsects.front().Address;
> 
> lwz 3, L..C0 at l(3) FixedValue should get the low 16bits of SectionMap[SymASec]->Address - TOCCsects.front().Address;
> 
> if I understand correct , the code need to change.
> 
> 
> 
Could you give an example that would generated non-0 FixedValue in TOCU position?
The example (the test case I have below) I tried before, TOCU position always have 0 as its FixedValue with system assembler generated object.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84549/new/

https://reviews.llvm.org/D84549