[PATCH] D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input.

[Ruijie Fang via Phabricator via llvm-commits]

rjf marked 3 inline comments as done.
rjf added a comment.

Comments addressed.



================
Comment at: llvm/lib/Transforms/IPO/HotColdSplitting.cpp:687
+  // Read in user-defined cold function names, if any.
+  if (ColdFunctionsList != "") {
+    std::stringstream CFStream(ColdFunctionsList);
----------------
vsk wrote:
> Might be better to use SpecialCaseList.h rather than hand-rolling something new.
It seems like the public API of `SpecialCaseList.h` only supports looking up whether a particular string is contained in the list, rather than retrieving all strings in the list. If we do this then we'll either have to a) traverse the entire module to match which function names in the current module are in the list, and mark them as cold, or b)  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85628/new/

https://reviews.llvm.org/D85628