[PATCH] D85804: [AMDGPU] Fix crash when dag-combining bitcast

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 05:34:41 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgcn.bitcast.ll:306
+define amdgpu_kernel void @bitcast_f32_to_v1i32(i32 addrspace(1)* %out) {
+  %f16 = call arcp afn half @llvm.canonicalize.f16(half 0xH03F0)
+  %f32 = fpext half %f16 to float
----------------
Does this need the constant canonicalize? I'd rather avoid relying on some specific constant folding behavior.

I'm also not sure how this produces a 64-bit value


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85804/new/

https://reviews.llvm.org/D85804



More information about the llvm-commits mailing list