[PATCH] D85805: [DWARFYAML] Make the address size of compilation units optional.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 01:51:58 PDT 2020


grimar added a comment.

In D85805#2212576 <https://reviews.llvm.org/D85805#2212576>, @Higuoxing wrote:

> In D85805#2212570 <https://reviews.llvm.org/D85805#2212570>, @grimar wrote:
>
>> Perhaps, you should be able to simplify some other test cases too with this change? I.e. to remove the 'AddrSize' field?
>
> Thanks! I will do it. Shall I simplify them in this change?

Yes, I think it is fine to do it in this change - when we introduce some functionality that simplifies things it is often reasonable to
apply it to the same patch to demostrate how much it is usable/useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85805/new/

https://reviews.llvm.org/D85805



More information about the llvm-commits mailing list