[PATCH] D76434: [SCEV] Query expanded immediate cost at minsize

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 01:41:52 PDT 2020


samparker added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:2408
     // And finally, the operands themselves should fit within the budget.
-    Worklist.insert(Worklist.end(), NAry->operands().begin(),
-                    NAry->operands().end());
+    if (CostKind == TTI::TCK_CodeSize) {
+      unsigned Idx = 0;
----------------
SjoerdMeijer wrote:
> This change here looks like an exact duplication of the change above (lines 2355 - 2362). Can this be in a helper?
Yeah, that would be nicer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76434/new/

https://reviews.llvm.org/D76434



More information about the llvm-commits mailing list