[PATCH] D85815: [clangd] Warn developers when trying to link system-installed gRPC statically

Kirill Bobyrev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 01:02:30 PDT 2020


kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: llvm-commits, usaxena95, kadircet, arphaman, jkorous, mgorny.
Herald added a project: LLVM.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85815

Files:
  llvm/cmake/modules/FindGRPC.cmake


Index: llvm/cmake/modules/FindGRPC.cmake
===================================================================
--- llvm/cmake/modules/FindGRPC.cmake
+++ llvm/cmake/modules/FindGRPC.cmake
@@ -21,6 +21,9 @@
   set(GRPC_CPP_PLUGIN $<TARGET_FILE:gRPC::grpc_cpp_plugin>)
   set(PROTOC ${Protobuf_PROTOC_EXECUTABLE})
 else()
+  if (NOT BUILD_SHARED_LIBS)
+    message(WARNING "gRPC and Protobuf will be linked dynamically. If you want static linking build gRPC from sources.")
+  endif()
   find_program(GRPC_CPP_PLUGIN grpc_cpp_plugin)
   find_program(PROTOC protoc)
   if (GRPC_CPP_PLUGIN-NOTFOUND OR PROTOC-NOTFOUND)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85815.284999.patch
Type: text/x-patch
Size: 612 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200812/08587a0c/attachment.bin>


More information about the llvm-commits mailing list