[PATCH] D85814: [X86][GlobalISel] Legalize G_ICMP results to s8.

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added reviewers: arsenm, paquette, aemerson, dsanders, volkan.
Herald added subscribers: hiraditya, rovka.
Herald added a project: LLVM.
craig.topper requested review of this revision.
Herald added a subscriber: wdng.

We need to produce a setcc instruction which has an 8-bit result.
This gets rid of a bunch of cases that were using the s1->s8/s16/s32/s64
handling in selectZExt.

I'm not very familiar with GlobalISel yet so I'm not yet sure
the best way to do things. I'd especially like feedback on the
best way to handle the currently split 32-bit and 64-bit mode
handling.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85814

Files:
  llvm/lib/Target/X86/X86LegalizerInfo.cpp
  llvm/test/CodeGen/X86/GlobalISel/cmp.ll
  llvm/test/CodeGen/X86/GlobalISel/legalize-cmp.mir
  llvm/test/CodeGen/X86/GlobalISel/legalize-phi.mir
  llvm/test/CodeGen/X86/GlobalISel/regbankselect-X86_64.mir
  llvm/test/CodeGen/X86/GlobalISel/select-cmp.mir
  llvm/test/CodeGen/X86/GlobalISel/select-phi.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85814.284996.patch
Type: text/x-patch
Size: 43872 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200812/37bda1a3/attachment.bin>