[PATCH] D79485: [BPI] Improve static heuristics for "cold" paths.

Evgeniy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 23:46:34 PDT 2020


ebrevnov added inline comments.


================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:643
+
+bool BranchProbabilityInfo::updateEstimatedBlockWeight(
+    LoopBlock &LoopBB, uint32_t BBWeight,
----------------
ebrevnov wrote:
> davidxl wrote:
> > document the method and params.
> sure
> sure

In fact, there is a documentation in header file. In source file I can put more details on behavior in case of rewrite attempt as you requested bellow. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79485/new/

https://reviews.llvm.org/D79485



More information about the llvm-commits mailing list