[PATCH] D84191: [llvm-objdump] Symbolize binary addresses for low-noisy asm diff.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

The last update looks good. Let's wait a bit for binutils' comment.. I also have a question about whether we should name the option `--symbolize-operands`, or is there a better name. It drops the existing offset/address operand as well as adding a symbol.



================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-symbololize-operands.yaml:1
+# RUN: yaml2obj %s --docnum=1 -o %t
+# RUN: llvm-objdump %t -d --symbolize-operands --x86-asm-syntax=intel --no-show-raw-insn --no-leading-addr | \
----------------
You can omit --docnum=1 since it is the only document


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2070
+                FOS << " <";
+                if (!Disp)
+                  // Always Print the binary symbol precisely corresponding to
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements

"Use braces for the `if` block to keep it uniform with the else block."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84191/new/

https://reviews.llvm.org/D84191