[PATCH] D83608: [NewPM][CodeGen] Introduce CodeGenPassBuilder to help build codegen pipeline

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 18:17:55 PDT 2020


ychen added inline comments.


================
Comment at: llvm/lib/CodeGen/LLVMTargetMachine.cpp:121
                                       MCContext &Context) {
+  Expected<std::unique_ptr<MCStreamer>> MCStreamerOrErr =
+      createMCStreamer(Out, DwoOut, FileType, Context);
----------------
Changes in this file are related to MCContext lifetime. MCContext is owned by MMI which is allocated & owned by the MachineFunctionAnalysisManager. Doing this allows us to delay the creation of MCStreamer when AsmPrinter is added to the pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83608/new/

https://reviews.llvm.org/D83608



More information about the llvm-commits mailing list