[PATCH] D85786: [lld-macho] Emit load command LC_BUILD_VERSION

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm!



================
Comment at: lld/MachO/Writer.cpp:255
+public:
+  LCBuildVersion(PlatformInfo &platform) : platform(platform) {}
+
----------------
nit: const ref


================
Comment at: lld/MachO/Writer.cpp:281
+
+  PlatformInfo &platform;
+};
----------------
const ref


================
Comment at: lld/test/MachO/lc-build-version.s:15
+# CHECK: version {{1[0-9]\.[0-9]}}
+# CHECK: Load command {{[0-9]+}}
+
----------------
JFYI, `[[#]]` will also match any number: https://llvm.org/docs/CommandGuide/FileCheck.html#filecheck-numeric-substitution-blocks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85786/new/

https://reviews.llvm.org/D85786