[PATCH] D81766: [VectorCombine] try to create vector loads from scalar loads

Steven Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 17:17:03 PDT 2020


srj added a comment.

> Can we just add another condition (!VectorSize) to this bailout?
> if (!ScalarSize || VectorSize % ScalarSize != 0)

Changing it to `if (!ScalarSize || !VectorSize || VectorSize % ScalarSize != 0)` does indeed seem to make our failure go away, so that would be fine as a quick fix.

(I'm still surprised that `getMinVectorRegisterBitWidth()` should ever return 0, but I can take that up with Qualcomm folks separately; it is entirely possible I don't understand the full semantics of that method.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81766/new/

https://reviews.llvm.org/D81766



More information about the llvm-commits mailing list