[PATCH] D85763: [flang] Copy attributes and flags onto host-assoc symbols

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 16:51:50 PDT 2020


tskeith added a comment.

In D85763#2211174 <https://reviews.llvm.org/D85763#2211174>, @PeteSteinfeld wrote:

> Rather than creating a new symbol, you could call `GetAssociationRoot` in check-deallocate.cpp at line 29:
>
>   } else if (!IsAllocatableOrPointer(
>                  *GetAssociationRoot(*symbol))) { // C932

We're already creating the HostAssocDetails symbols, this change is about getting the right attributes on them. We can follow the associations to test for pointer and allocatable, but some attributes can be on the HostAssocDetails symbol so in those cases we need to check both symbols. This is simpler and similar to how use-association symbols are managed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85763/new/

https://reviews.llvm.org/D85763



More information about the llvm-commits mailing list