[PATCH] D71539: [SCEV] Look through trivial PHIs.

Bardia Mahjour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 13:55:23 PDT 2020


bmahjour accepted this revision.
bmahjour added a comment.
This revision is now accepted and ready to land.

> This patch only improves things for LCSSA phis, not for other trivial phis (multiple equal incoming values).

It would be good clarify this in the title then.

> I can look into how this fits in now as a follow up.

That would be appreciated. Are there any particular concerns with the proposed fix under D71492 <https://reviews.llvm.org/D71492>? I'd suppose there would be no SCEVExpander concerns (unlike LCSSA phis) since "multiple equal incoming value phis" are not really a form that have to be preserved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71539/new/

https://reviews.llvm.org/D71539



More information about the llvm-commits mailing list