[PATCH] D83034: [GlobalISel] Don't skip adding predicate matcher

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/TableGen/ContextlessPredicates.td:13
+	                                             (atomic_swap node:$ptr, node:$val)> {
+  let GISelPredicateCode = [{ dbgs() <<  return !MRI.use_nodbg_empty(MI.getOperand(0).getReg()); }];
+  let IsAtomic = 1;
----------------
Don't need dbgs() << here (not that you really need anything)


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3665
+      InsnMatcher.addPredicate<AtomicOrderingMMOPredicateMatcher>("Monotonic");
+      return InsnMatcher;
+    }
----------------
How is changing this to return any different than continue? It's still treating all of these as mutually exclusive


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3770
       continue;
+    } else if (!HasAddedBuiltinMatcher) {
+      return failedImport("Src pattern child has predicate (" +
----------------
No else after continue


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83034/new/

https://reviews.llvm.org/D83034