[PATCH] D85763: [flang] Copy attributes and flags onto host-assoc symbols

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 11:54:54 PDT 2020


tskeith added a comment.

In D85763#2210944 <https://reviews.llvm.org/D85763#2210944>, @klausler wrote:

> What if the attributes of the host symbol change after the association symbol is created?  It might be safer to fetch the attributes and flags from the original host symbol when they're needed.

I don't think that can happen because we process the host first, though I'm not positive.

Doing it when requested means we need to know which attributes we look for on the local symbol and which on the host symbol (or maybe it works to check both).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85763/new/

https://reviews.llvm.org/D85763



More information about the llvm-commits mailing list