[PATCH] D85740: Universal MachO: support LLVM IR objects

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

@aguinet, 
thanks for the patch!

1. This code has been recently refactored (see https://github.com/llvm/llvm-project/commit/df69492cdfa82ff6453c887cd45b3a5903b79afb ) so you'd need to rebase your diff.
2. Bitcode files can also come from archives (static libraries)  (e.g. an archive can contain bitcode files exclusively) - so when we create a Slice from an archive we also need to handle that.
3. We need tests.

Somewhat related to this area - If I'm not mistaken there is a small issue in SymbolicFile::createSymbolicFile - when LLVMContext is null the function appears to return a misleading error - I was planning to fix that soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85740/new/

https://reviews.llvm.org/D85740