[PATCH] D85458: Adding functionality to Stack Tracing

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: llvm/unittests/Support/CrashRecoveryTest.cpp:94
 
+#if !defined(_WIN32)
+TEST(CrashRecoveryTest, LimitedStackTrace) {
----------------
aganea wrote:
> We're trying to avoid platform-specific includes as much as possible. In this case, you would still want to compile the code on all platforms, but dynamically skip the parts that don't work yet. So in essence, please remove the #if / #endif lines, and enclose the EXPECT_EQ into a test:
> ```
> // FIXME: (instruct to fix the Windows implementation for PrintStackTrace)
> if (!Triple(sys::getProcessTriple()).isOSWindows())
>   EXPECT_EQ(...)
> ```
> 
I meant platform-specific defines, not includes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85458/new/

https://reviews.llvm.org/D85458