[PATCH] D84748: [cmake] Make gtest macro definitions a part the library interface

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 06:24:32 PDT 2020


labath added a comment.

In D84748#2178809 <https://reviews.llvm.org/D84748#2178809>, @ldionne wrote:

> Can you confirm that all the targets that need to "link" (in the CMake sense) against gtest use the gtest CMake target?

I wouldn't use the word "confirm" but I did check that I am able to run test for subprojects I have modified (in their default configs) and that no other subprojects define these macros.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84748/new/

https://reviews.llvm.org/D84748



More information about the llvm-commits mailing list