[PATCH] D85707: [DWARFYAML] Let the address size of line tables inferred from the object file.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 05:40:52 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:474
         case dwarf::DW_LNE_set_discriminator:
-          // TODO: Test this error.
-          if (Error Err = writeVariableSizedInteger(
-                  Op.Data, DI.CompileUnits[0].AddrSize, OS, DI.IsLittleEndian))
-            return Err;
+          // FIXME: The operands of set_discriminator is not an address.
+          cantFail(writeVariableSizedInteger(Op.Data, AddrSize, OS,
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85707/new/

https://reviews.llvm.org/D85707



More information about the llvm-commits mailing list