[PATCH] D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 03:49:35 PDT 2020


Orlando updated this revision to Diff 284641.
Orlando edited the summary of this revision.
Orlando added a comment.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

Hi @dstenb, thanks for taking a look. I've updated the diff to include a test but it feels a little unwieldy. Is there a better way to test this?

I've also fixed a bug (good idea to request a test...) and renamed the stat to better reflect its purpose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85636/new/

https://reviews.llvm.org/D85636

Files:
  llvm/test/tools/llvm-dwarfdump/X86/statistics-dwo.test
  llvm/test/tools/llvm-dwarfdump/X86/statistics-v3.test
  llvm/test/tools/llvm-dwarfdump/X86/statistics.ll
  llvm/test/tools/llvm-dwarfdump/X86/stats-scope-bytes-covered.s
  llvm/tools/llvm-dwarfdump/Statistics.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85636.284641.patch
Type: text/x-patch
Size: 28175 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200811/d3777ca4/attachment.bin>


More information about the llvm-commits mailing list