[PATCH] D81667: [RFC, FileCheck] Add precision to format specifier

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:742-743
+ ``<precision>`` indicates the minimum number of digits that the value matched
+ must have, expecting leading zeros should the value be too small to have that
+ many digits.
+
----------------
jhenderson wrote:
> Should we say something about leading zeros beyond those required by the precision value?
Is that what you expected?


================
Comment at: llvm/lib/Support/FileCheck.cpp:49
+  if (Precision) {
+    const char *RegexPrefix;
+
----------------
jhenderson wrote:
> `StringRef`?
ostringstream below does not understand StringRef so I would need to do .str() which can be expensive. Any reason not to keep const char*?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81667/new/

https://reviews.llvm.org/D81667