[PATCH] D85632: [Attributor] Implement AAPotentialValues

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

I think this patch is good. We should try to limit the queries to useful ones. We can do that after though. Maybe we check the instruction opcode in `getAssumedConstantInt` to make sure we only run this for Instructions that can fold multiple values into a single one, so far probably only compare instructions. We could also add a separate method that determines if this `AAValueSimplify`-like AA is good for a certain position or not. Either way, that should result in way less iterations without loosing any optimizations. Feel free to give it a try :)

LGTM.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:7426
+        if (MaybeTrue & MaybeFalse)
+          break;
+      }
----------------
You can indicate a pessimistic fixpoint here. It's an `i1` which can be true and false :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85632/new/

https://reviews.llvm.org/D85632