[PATCH] D85668: [Attributor][NFC] Connect AAPotentialValues with AAValueSimplify

[Shinji Okumura via Phabricator via llvm-commits]

okura added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:4493
+    if (!COpt.hasValue()) {
+      failAll = false;
+      return false;
----------------
jdoerfert wrote:
> I'm not sure we need/want this failAll flag. Can't we just return true, given that `::None` is the right simplified value in that case? With the current setup we will always call `AAPotentialValues`, even if the range analysis would determine a constant result eventually.
> Can't we just return true, given that ::None is the right simplified value in that case?
I thought llvm::None is a weaker result than concrete ConstantInt values, but that was my mistake. I'll fix this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85668/new/

https://reviews.llvm.org/D85668