[PATCH] D84822: Add target ID to AMDGPU documentation

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Can you add the proposed commit message to the phab diff as well? The commit subject does by far not cover changes like "Embedding Bundled Code Objects".



================
Comment at: clang/docs/ClangOffloadBundlerFileFormat.rst:88
+in `AMDGPU Embedding Bundled Code Objects
+  <https://llvm.org/docs/AMDGPUUsage.html#embedding-bundled-objects>`_.
----------------
yaxunl wrote:
> jdoerfert wrote:
> > This is not generic and ignores the fact that we use this tool for non-AMDGPU targets. The target-id description above does too.
> fixed
It is still completely unclear how non AMDGPU targets use this. The description is confusing IMHO. Specifically, the `<bundle_entry_id>` specifies `"-" <processor_or_target_id>` but it is unclear what that means for other targets, given that the `processor_or_target_id` description links to the AMDGPU docs. If you want to say other targets do not use the target_id at all, so there is nothing, please specify say that explicitly. If there is something, we have to say something about that as well, at least that there are alternatives to the AMDGPU way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822