[PATCH] D85617: [OpenMP][OMPBuilder] Adding support for `omp single`

[Fady Ghanim via Phabricator via llvm-commits]

fghanim added a comment.

Thanks. will fix nits.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:318
+  /// \param CpyFn function to call for copying data
+  /// \param DidIt flag variable; 1 for 'single' thread, 0 otherwise
+  ///
----------------
kiranchandramohan wrote:
> what is the full form of this name?
> Would IsSingle be a better name?
> what is the full form of this name?
> Would IsSingle be a better name?

That's the name used for it in the runtime. While it doesn't really matter, I am just using same name to be consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85617/new/

https://reviews.llvm.org/D85617