[PATCH] D85664: [SampleFDO] Stop letting findCalleeFunctionSamples return unrelated profiles for invoke instructions

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 10:28:39 PDT 2020


wmi added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:823
   StringRef CalleeName;
-  if (const CallInst *CI = dyn_cast<CallInst>(&Inst))
-    if (Function *Callee = CI->getCalledFunction())
----------------
wenlei wrote:
> So the original differentiation between invoke and call here isn't intentional, but purely an implementation oversight?
I think so. I don't see fundamental difference between call and invoke with regard to sampleFDO. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85664/new/

https://reviews.llvm.org/D85664



More information about the llvm-commits mailing list