[PATCH] D85658: [RDA] Fix DBG_VALUE issues

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

This LGTM, with some thoughts on how this could be improved in a followup.



================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:501
   return true;
 }
 
----------------
The general approach in this function looks a bit dubious to me. Instead of passing in the last instruction to `getReachingDef()`, we should add a function that gets the reaching def at the end of the block. This can be found by inspecting the last element in the reaching def vector, rather than scanning the whole vector, and has the advantage that it will automatically include reaching defs from the last instruction. From a cursory look, I suspect that the current implementation has a discrepancy in handling of aliased registers for the last instruction, because reg units are not inspected for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85658/new/

https://reviews.llvm.org/D85658