[PATCH] D85642: [LLD][ELF] - Update and fix gnu-ifunc* tests.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 05:33:25 PDT 2020


grimar created this revision.
grimar added reviewers: MaskRay, peter.smith.
Herald added a subscriber: emaste.
Herald added a reviewer: espindola.
grimar requested review of this revision.

It turns that gnu-ifunc-plt-i386.s and gnu-ifunc-plt.s tests are broken.

Initially they were implemented in D27581 <https://reviews.llvm.org/D27581> and tested that `IRELATIVE` relocations
are placed after other relocations in `.rel.plt`.

Later, we started to place `IRELATIVE` relocations to `.rela.dyn` (D65651 <https://reviews.llvm.org/D65651>).

Also, at some point `.plt` was renamed to `.iplt` (D71520 <https://reviews.llvm.org/D71520>).

Now, `gnu-ifunc*` tests mentioned do not test what they intended to test initially:
they should test that `IRELATIVE` relocations are placed after other ones in
`.rela.dyn`. Also, comments needs to be updated accordingly after changes performed.

This patch updates them.


https://reviews.llvm.org/D85642

Files:
  lld/test/ELF/Inputs/shared2-x86-64.s
  lld/test/ELF/gnu-ifunc-plt-i386.s
  lld/test/ELF/gnu-ifunc-plt.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85642.284327.patch
Type: text/x-patch
Size: 10201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200810/c1733f16/attachment.bin>


More information about the llvm-commits mailing list