[PATCH] D85618: [ELF] Move the outSecOff addend from relocAlloc/relocNonAlloc/... to InputSectionBase::relocate

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 03:35:54 PDT 2020


grimar added a comment.

In D85618#2205936 <https://reviews.llvm.org/D85618#2205936>, @psmith wrote:

> Simplification looks good to me.

+1.

> I'm not sure about the test changes as I would have expected the change to be NFC. If these are test improvements it will be worth altering separately.

+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85618/new/

https://reviews.llvm.org/D85618



More information about the llvm-commits mailing list