[PATCH] D85517: [Scheduling] Implement a new way to cluster loads/stores

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 02:01:42 PDT 2020


foad added a comment.

Thanks for the detailed explanations! The test case diffs all look good to me now.

Perhaps in the future we can find some way to preserve original code order for clusters of more than two instructions. (Or even better, find a way to cluster them without enforcing any particular order at all. I.e. a way to say to the scheduler "I want these units to be adjacent but I don't care which one comes first.")



================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1593
+
+    // Seak for the next load/store to do the cluster.
+    unsigned NextIdx = Idx + 1;
----------------
Typo "seek".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85517/new/

https://reviews.llvm.org/D85517



More information about the llvm-commits mailing list