[PATCH] D85526: [llvm-readobj] - Refine program headers testing (`-l`, `--program-headers` and `--segment`).

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 01:05:43 PDT 2020


grimar added a comment.

In D85526#2205529 <https://reviews.llvm.org/D85526#2205529>, @MaskRay wrote:

> Except that.... program-headers.test has some llvm-readobj RUN lines. Note that we still need some representative tests for the LLVM style.

Yeah, that is why I've added `llvm-readobj` testing to `gnu-phdrs.test`

>> I am also not sure if we want to rename gnu-phdrs.test to something (e.g to program-headers.test) in this patch or is it better to do in a "NFC" follow-up? (for better commit history and to avoid confusion).
>
> Do you want to add some llvm-readobj RUN lines to gnu-phdrs.test so that it will become a misnomer to call the test `gnu-*`?

I've already did it in this patch. So yes, currently it's name is `gnu-*`, though it tests LLVM style too now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85526/new/

https://reviews.llvm.org/D85526



More information about the llvm-commits mailing list