[PATCH] D85345: [BuildLibCalls] Add noundef to standard I/O functions

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, assuming the fixes to the failing tests are straight forward.



================
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:509
+    Changed |= setDoesNotThrow(F);
+    Changed |= setDoesNotCapture(F, 1);
+    return Changed;
----------------
aqjune wrote:
> jdoerfert wrote:
> > I'd split it into noundef and other attributes. noundef is so new that we should keep that separate, having the others in a single patch is fine with me though.
> Hi,
> These attributes existed in the past - they are copied from lines 514-515.
> This change was made because noundef is not added to frexp/frexpl/frexpf in this patch, which can possibly make those unspeculatable.
I see.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85345/new/

https://reviews.llvm.org/D85345