[PATCH] D85592: [Attributor] Add flag for undef value to the state of AAPotentialValues

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 9 09:54:59 PDT 2020


jdoerfert added a comment.

Cool. I think the code is fine, one minor simplification to consider below. We need tests though.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:3442-3444
+    if (UndefIsContained && Set.size() > 0) {
+      UndefIsContained = false;
+    }
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85592/new/

https://reviews.llvm.org/D85592



More information about the llvm-commits mailing list