[PATCH] D85280: [Polly] Reuse LLVM's build rules for gtest/gmock

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 9 03:54:01 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rGc8b629a3a585: [Polly] Reuse LLVM's build rules for gtest/gmock (authored by mgorny).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85280/new/

https://reviews.llvm.org/D85280

Files:
  polly/CMakeLists.txt


Index: polly/CMakeLists.txt
===================================================================
--- polly/CMakeLists.txt
+++ polly/CMakeLists.txt
@@ -27,35 +27,16 @@
   set(POLLY_GTEST_AVAIL 0)
   set(UNITTEST_DIR ${LLVM_SOURCE_ROOT}/utils/unittest)
   if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h)
-    # The build tree already exports the gtest target, which we can reuse
-    if (TARGET gtest)
-      # LLVM Doesn't export gtest's include directorys, so do that here
-      set_target_properties(gtest
-        PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
-        "${UNITTEST_DIR}/googletest/include;${UNITTEST_DIR}/googlemock/include"
-        )
-      set(POLLY_GTEST_AVAIL 1)
-    else()
-      add_library(gtest
-        ${UNITTEST_DIR}/googletest/src/gtest-all.cc
-        ${UNITTEST_DIR}/googlemock/src/gmock-all.cc
-        )
-      target_include_directories(gtest
-        PUBLIC
-        "${UNITTEST_DIR}/googletest/include"
-        "${UNITTEST_DIR}/googlemock/include"
-
-        PRIVATE
-        "${UNITTEST_DIR}/googletest"
-        "${UNITTEST_DIR}/googlemock"
-        )
-      target_link_libraries(gtest PUBLIC -lpthread)
-
-      add_library(gtest_main ${UNITTEST_DIR}/UnitTestMain/TestMain.cpp)
-      target_link_libraries(gtest_main PUBLIC gtest)
-
-      set(POLLY_GTEST_AVAIL 1)
+    if (NOT TARGET gtest)
+      add_subdirectory(${UNITTEST_DIR} utils/unittest)
     endif()
+
+    # LLVM Doesn't export gtest's include directorys, so do that here
+    set_target_properties(gtest
+      PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
+      "${UNITTEST_DIR}/googletest/include;${UNITTEST_DIR}/googlemock/include"
+      )
+    set(POLLY_GTEST_AVAIL 1)
   endif()
 
   # Make sure the isl c files are built as fPIC


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85280.284184.patch
Type: text/x-patch
Size: 1747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200809/9fd19cae/attachment.bin>


More information about the llvm-commits mailing list