[llvm] cfd2ee2 - [llvm-readobj] - Remove 3 excessive test cases.

Georgii Rymar via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 9 01:09:33 PDT 2020


Author: Georgii Rymar
Date: 2020-08-09T11:00:49+03:00
New Revision: cfd2ee29e0e23fe4174740a97cc001c8b7a21475

URL: https://github.com/llvm/llvm-project/commit/cfd2ee29e0e23fe4174740a97cc001c8b7a21475
DIFF: https://github.com/llvm/llvm-project/commit/cfd2ee29e0e23fe4174740a97cc001c8b7a21475.diff

LOG: [llvm-readobj] - Remove 3 excessive test cases.

This patch does the following:

1) Removes mips-options.test and the corresponding Inputs/mips-options.elf-mips64el binary:
This is a test that checks that --dynamic-table is able to print the DT_MIPS_OPTIONS tag.
We are testing it in dynamic-tags-machine-specific.test already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L235)

2) Removes mips-rld-map-rel.test and the corresponding Inputs/mips-rld-map-rel.elf-mipsel binary.
This is a test that checks that --dynamic-table is able to print the DT_MIPS_RLD_MAP_REL tag.
We are testing it in dynamic-tags-machine-specific.test already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L257)

3) Removes ppc64-glink.test test and the corresponding Inputs/ppc64.exe binary.
This is a test that checks that --dynamic-table is able to print the DT_PPC64_GLINK tag.
We are testing it in dynamic-tags-machine-specific.test already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L337)

Differential revision: https://reviews.llvm.org/D85515

Added: 
    

Modified: 
    

Removed: 
    llvm/test/tools/llvm-readobj/ELF/Inputs/mips-options.elf-mips64el
    llvm/test/tools/llvm-readobj/ELF/Inputs/mips-rld-map-rel.elf-mipsel
    llvm/test/tools/llvm-readobj/ELF/Inputs/ppc64.exe
    llvm/test/tools/llvm-readobj/ELF/mips-options.test
    llvm/test/tools/llvm-readobj/ELF/mips-rld-map-rel.test
    llvm/test/tools/llvm-readobj/ELF/ppc64-glink.test


################################################################################
diff  --git a/llvm/test/tools/llvm-readobj/ELF/Inputs/mips-options.elf-mips64el b/llvm/test/tools/llvm-readobj/ELF/Inputs/mips-options.elf-mips64el
deleted file mode 100644
index 4b6525731dd7..000000000000
Binary files a/llvm/test/tools/llvm-readobj/ELF/Inputs/mips-options.elf-mips64el and /dev/null 
diff er

diff  --git a/llvm/test/tools/llvm-readobj/ELF/Inputs/mips-rld-map-rel.elf-mipsel b/llvm/test/tools/llvm-readobj/ELF/Inputs/mips-rld-map-rel.elf-mipsel
deleted file mode 100644
index a8e396c2ec36..000000000000
Binary files a/llvm/test/tools/llvm-readobj/ELF/Inputs/mips-rld-map-rel.elf-mipsel and /dev/null 
diff er

diff  --git a/llvm/test/tools/llvm-readobj/ELF/Inputs/ppc64.exe b/llvm/test/tools/llvm-readobj/ELF/Inputs/ppc64.exe
deleted file mode 100644
index 0db6147ca70a..000000000000
Binary files a/llvm/test/tools/llvm-readobj/ELF/Inputs/ppc64.exe and /dev/null 
diff er

diff  --git a/llvm/test/tools/llvm-readobj/ELF/mips-options.test b/llvm/test/tools/llvm-readobj/ELF/mips-options.test
deleted file mode 100644
index 0d0ec7e55401..000000000000
--- a/llvm/test/tools/llvm-readobj/ELF/mips-options.test
+++ /dev/null
@@ -1,22 +0,0 @@
-## Check DT_MIPS_OPTIONS .dynamic section tag reading
-
-# RUN: llvm-readobj --dynamic-table %p/Inputs/mips-options.elf-mips64el | \
-# RUN:   FileCheck %s
-
-# CHECK:      DynamicSection [ (14 entries)
-# CHECK-NEXT:   Tag                Type                 Name/Value
-# CHECK-NEXT:   0x0000000000000004 HASH                 0x158
-# CHECK-NEXT:   0x0000000000000005 STRTAB               0x1C0
-# CHECK-NEXT:   0x0000000000000006 SYMTAB               0x178
-# CHECK-NEXT:   0x000000000000000A STRSZ                7 (bytes)
-# CHECK-NEXT:   0x000000000000000B SYMENT               24 (bytes)
-# CHECK-NEXT:   0x0000000070000001 MIPS_RLD_VERSION     1
-# CHECK-NEXT:   0x0000000070000005 MIPS_FLAGS           NOTPOT
-# CHECK-NEXT:   0x0000000070000006 MIPS_BASE_ADDRESS    0x0
-# CHECK-NEXT:   0x000000007000000A MIPS_LOCAL_GOTNO     2
-# CHECK-NEXT:   0x0000000070000011 MIPS_SYMTABNO        3
-# CHECK-NEXT:   0x0000000070000013 MIPS_GOTSYM          0x3
-# CHECK-NEXT:   0x0000000000000003 PLTGOT               0x2000
-# CHECK-NEXT:   0x0000000070000029 MIPS_OPTIONS         0x1000
-# CHECK-NEXT:   0x0000000000000000 NULL                 0x0
-# CHECK-NEXT: ]

diff  --git a/llvm/test/tools/llvm-readobj/ELF/mips-rld-map-rel.test b/llvm/test/tools/llvm-readobj/ELF/mips-rld-map-rel.test
deleted file mode 100644
index 00198bbfe757..000000000000
--- a/llvm/test/tools/llvm-readobj/ELF/mips-rld-map-rel.test
+++ /dev/null
@@ -1,24 +0,0 @@
-## Check DT_MIPS_RLD_MAP_REL .dynamic section tag reading
-
-# RUN: llvm-readobj --dynamic-table %p/Inputs/mips-rld-map-rel.elf-mipsel | \
-# RUN:   FileCheck %s
-
-# CHECK:      DynamicSection [ (16 entries)
-# CHECK-NEXT:   Tag                Type                 Name/Value
-# CHECK-NEXT:   0x00000004 HASH                 0x220
-# CHECK-NEXT:   0x00000005 STRTAB               0x2FC
-# CHECK-NEXT:   0x00000006 SYMTAB               0x25C
-# CHECK-NEXT:   0x0000000A STRSZ                72 (bytes)
-# CHECK-NEXT:   0x0000000B SYMENT               16 (bytes)
-# CHECK-NEXT:   0x70000035 MIPS_RLD_MAP_REL     0x101E0
-# CHECK-NEXT:   0x00000015 DEBUG                0x0
-# CHECK-NEXT:   0x00000003 PLTGOT               0x10390
-# CHECK-NEXT:   0x70000001 MIPS_RLD_VERSION     1
-# CHECK-NEXT:   0x70000005 MIPS_FLAGS           NOTPOT
-# CHECK-NEXT:   0x70000006 MIPS_BASE_ADDRESS    0x0
-# CHECK-NEXT:   0x7000000A MIPS_LOCAL_GOTNO     2
-# CHECK-NEXT:   0x70000011 MIPS_SYMTABNO        10
-# CHECK-NEXT:   0x70000012 MIPS_UNREFEXTNO      15
-# CHECK-NEXT:   0x70000013 MIPS_GOTSYM          0xA
-# CHECK-NEXT:   0x00000000 NULL                 0x0
-# CHECK-NEXT: ]

diff  --git a/llvm/test/tools/llvm-readobj/ELF/ppc64-glink.test b/llvm/test/tools/llvm-readobj/ELF/ppc64-glink.test
deleted file mode 100644
index d173c985b5f2..000000000000
--- a/llvm/test/tools/llvm-readobj/ELF/ppc64-glink.test
+++ /dev/null
@@ -1,11 +0,0 @@
-# Check DT_PPC64_GLINK dynamic tag.
-
-RUN: llvm-readobj --dynamic-table %p/Inputs/ppc64.exe | FileCheck %s
-
-CHECK: Format: elf64-powerpc
-CHECK: Arch: powerpc64le
-CHECK: AddressSize: 64bit
-
-CHECK:      DynamicSection [ (25 entries)
-CHECK-NEXT:   Tag                Type                 Name/Value
-CHECK:        0x0000000070000000 PPC64_GLINK          0x10000830


        


More information about the llvm-commits mailing list