[PATCH] D85480: [NFC] Use value initializer for OVERLAPPED

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 17:02:30 PDT 2020


amccarth added a comment.

OK, I see.  I was looking at the wrong field.

I'm not sure I see the value in this warning.  I'd argue the replacement code is less clear.  It's contrary to the entrenched idiom for Win32 programming.  The old code in valid and correct in both C and C++, but the new code is not allowed in C.

"In C, the braced list of initializers cannot be empty (note that C++ allows empty lists ...)."  https://en.cppreference.com/w/c/language/struct_initialization


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85480/new/

https://reviews.llvm.org/D85480



More information about the llvm-commits mailing list