[PATCH] D85455: [XCOFF][AIX] Use TE storage mapping class when large code model is enabled

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 13:14:54 PDT 2020


Xiangling_L added a comment.

> so that code compiled with large code model TOC reference would not
> take up spaces from the normal small code model TOC reference.

Probably we need to rephrase the description here.
As my understanding, TE SMC entry is possible to take spaces from the normal small code model TOC reference?  But it would let TC SMC entry take up those space first and TE then follows.



================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2204
+      cast<MCSymbolXCOFF>(Sym)->getSymbolTableName(),
+      IsLarge ? XCOFF::XMC_TE : XCOFF::XMC_TC, XCOFF::XTY_SD, XCOFF::C_HIDEXT,
+      SectionKind::getData());
----------------
Slightly prefer inline `IsLarge` since it's used once and also not too long.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85455/new/

https://reviews.llvm.org/D85455



More information about the llvm-commits mailing list