[PATCH] D84803: [ThinLTO][MachO] Preserve both possible GUIDs from exported list

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 12:45:03 PDT 2020


tejohnson added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/mangled_symbol.ll:8
+; REGULAR: define void @"\01_extern_mangled"
+; INTERNALIZE: define void @extern_not_mangled
+; INTERNALIZE: define void @"\01_extern_mangled"
----------------
Is the output meant be the exact same in the REGULAR and INTERNALIZE cases? I'm confused as to what this is testing. Comments in the test would help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84803/new/

https://reviews.llvm.org/D84803



More information about the llvm-commits mailing list