[PATCH] D85501: [lld-macho] Handle command-line option -sectcreate SEG SECT FILE

[Greg McGary via Phabricator via llvm-commits]

gkm added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:313
+  isec->data = {buf, mb.getBufferSize()};
+  subsections.push_back({{0, isec}});
+}
----------------
int3 wrote:
> nit: `subsections.emplace_back({0, isec});`
I followed prior practice in `InputFile::parseSections`. If I follow your recommendation, it seems I should also fix `InputFile::parseSections`, but then I am straying from the purpose of this diff into cleanup territory. Perhaps we should rather save cleanups for a separate diff, which could also include explicit `const auto`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85501/new/

https://reviews.llvm.org/D85501