[PATCH] D83852: [llvm-profdata] Implement llvm-profdata overlap for sample profiles

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 11:00:15 PDT 2020


hoyFB added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:811-817
+  bool areBothFinished() {
+    return (FirstIter == FirstEnd && SecondIter == SecondEnd);
+  }
+
+  bool isFirstFinished() { return FirstIter == FirstEnd; }
+
+  bool isSecondFinished() { return SecondIter == SecondEnd; }
----------------
Can you please decorate these functions with `const`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83852/new/

https://reviews.llvm.org/D83852



More information about the llvm-commits mailing list