[PATCH] D84765: [AIX][XCOFF] [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations

[Digger via Phabricator via llvm-commits]

DiggerLin marked 2 inline comments as done.
DiggerLin added a comment.

In D84765#2199956 <https://reviews.llvm.org/D84765#2199956>, @Xiangling_L wrote:

> As you mentioned in the summary, this patch seems be addressing two orthogonal things:
>
> 1. remove SC from MCSectionXCOFF and let it only be a property of MCSymbolXCOFF
> 2. when branching to an undefined function, branch to qualname instead.
>
> If I am right, I would suggest we split them into two patches.
>
> And for the second patch `when branching to an undefined function, branch to qualname instead`, I think we need to adjust the patch title to a more accurate one[maybe `[AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations`]since the scope is actually limited to function declarations only.



In D84765#2199956 <https://reviews.llvm.org/D84765#2199956>, @Xiangling_L wrote:

> As you mentioned in the summary, this patch seems be addressing two orthogonal things:
>
> 1. remove SC from MCSectionXCOFF and let it only be a property of MCSymbolXCOFF
> 2. when branching to an undefined function, branch to qualname instead.
>
> If I am right, I would suggest we split them into two patches.
>
> And for the second patch `when branching to an undefined function, branch to qualname instead`, I think we need to adjust the patch title to a more accurate one[maybe `[AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations`]since the scope is actually limited to function declarations only.



In D84765#2199956 <https://reviews.llvm.org/D84765#2199956>, @Xiangling_L wrote:

> As you mentioned in the summary, this patch seems be addressing two orthogonal things:
>
> 1. remove SC from MCSectionXCOFF and let it only be a property of MCSymbolXCOFF
> 2. when branching to an undefined function, branch to qualname instead.
>
> If I am right, I would suggest we split them into two patches.
>
> And for the second patch `when branching to an undefined function, branch to qualname instead`, I think we need to adjust the patch title to a more accurate one[maybe `[AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations`]since the scope is actually limited to function declarations only.

you can take a look on the first diff of the patch.  I tried to  do "remove SC from MCSectionXCOFF and let it only be a property of MCSymbolXCOFF" only in the first diff.
if only remove SC from MCSectionXCOFF,  the emitLinkage set the storageClass of the symbol which is not qualname represent symbol of the   MCSectionXCOFF. I need to add
some middle source code (in llvm/lib/MC/MCXCOFFStreamer.cpp of first patch) to set the storageClasss of the qualname represent symbol of the   MCSectionXCOFF. and the code will be removed later when we implement the second patch. It will waste our time to review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84765/new/

https://reviews.llvm.org/D84765