[PATCH] D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:42
+static cl::opt<bool>
+EnablePCRelLinkerOpt("ppc-pcrel-linker-opt", cl::Hidden, cl::init(true),
+                     cl::desc("enable PC Relative linker optimization"));
----------------
NeHuang wrote:
> nit: clang-format
I would rather not do clang-format here. I want to have this option look the same as the other one after it.

I can clang-format both options in an NFC patch later.


================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-linkeropt-option.ll:3
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN:   -mcpu=future -ppc-asm-full-reg-names -ppc-vsr-nums-as-vr \
+; RUN:   < %s | FileCheck %s --check-prefix=DEFAULT
----------------
NeHuang wrote:
> nit: can we use `-mcpu=pwr10` here?
Thank you for catching that.
That's a copy-paste. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85377/new/

https://reviews.llvm.org/D85377