[PATCH] D84250: [InstSimplify] ExpandBinOp should fold an expression only when it's safe

Fri Aug 7 09:16:50 PDT 2020

aqjune abandoned this revision.
aqjune added a comment.

In D84250#2202791 <https://reviews.llvm.org/D84250#2202791>, @spatel wrote:

> I don't have a preference, but others said they would like go with D84792 <https://reviews.llvm.org/D84792>, so let's do that.

Well, okay. It is moving toward being more correct anyway, so it's good.

In D84250#2201322 <https://reviews.llvm.org/D84250#2201322>, @kazu wrote:

> Is there something left to improve in this patch?  I'm asking this because a fix for https://bugs.llvm.org/show_bug.cgi?id=46940 builds on this fix, so I'd like to see this patch checked in if there is no pending issues.  Thanks!

Hello @kazu, sorry for making a confusion.
If D84792 <https://reviews.llvm.org/D84792> lands, you can instead try calling `SimplifyBinOp` with giving false to SQ.CanUseUndef and check whether the bug disappears.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84250/new/

https://reviews.llvm.org/D84250