[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

[Digger via Phabricator via llvm-commits]

DiggerLin marked 4 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:887
+  uint64_t Offset = 0;
+  unsigned ParmNum = 0;
+
----------------
hubert.reinterpretcast wrote:
> DiggerLin wrote:
> > hubert.reinterpretcast wrote:
> > > Please reduce the scope of `ParmNum` by merging the adjacent blocks that set and use it.
> > thanks
> My request was to have the scope of `ParmNum` reduced. That is, please move the declaration of `ParmNum` to where it is set and used (and also arrange for it to be in a smaller block scope that does not extend much further than the point where `ParmNum` is used).
thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585