[PATCH] D85516: [SVE][CodeGen] Fix issues with EXTRACT_SUBVECTOR when using scalable FP vectors

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 04:53:52 PDT 2020


david-arm created this revision.
david-arm added reviewers: sdesmalen, efriedma, kmclaughlin.
Herald added subscribers: llvm-commits, psnobl, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
david-arm requested review of this revision.

In this patch I have fixed two issues:

1. Our SVE tuple get/set intrinsics were using the wrong constant type

for the index passed to EXTRACT_SUBVECTOR. I have fixed this to use an integer
pointer type.

2. The AArch64 backend was missing the appropriate patterns for

extracting certain subvectors (nxv4f16 and nxv2f32) from legal SVE types.
I have added them as part of this patch.

The only way that I could find to test the new patterns was to use the
SVE tuple get intrinsics, although I realise it looks a bit unusual.
Tests added here:

  test/CodeGen/AArch64/sve-extract-subvector.ll


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85516

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
  llvm/test/CodeGen/AArch64/sve-extract-subvector.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85516.283870.patch
Type: text/x-patch
Size: 5453 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200807/a5b6b88d/attachment.bin>


More information about the llvm-commits mailing list