[PATCH] D85506: [macho2yaml] Refactor the DWARF section dumpers.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 02:19:58 PDT 2020


grimar added inline comments.


================
Comment at: llvm/tools/obj2yaml/macho2yaml.cpp:153
+  return createStringError(errc::not_supported,
+                           "dumping " + SecName + " section is not supported");
+}
----------------
Perhaps we need a test for an unknown debug section to test this?
E.g. a test for an arbitrary "__debug_foo" that shows that we are able to and actually emit a raw content for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85506/new/

https://reviews.llvm.org/D85506



More information about the llvm-commits mailing list